From owner-sc22wg5+sc22wg5-dom9=www.open-std.org@open-std.org Tue Oct 6 20:08:49 2020 Return-Path: X-Original-To: sc22wg5-dom9 Delivered-To: sc22wg5-dom9@www.open-std.org Received: by www.open-std.org (Postfix, from userid 521) id 4FCB33587CB; Tue, 6 Oct 2020 20:08:49 +0200 (CEST) Delivered-To: sc22wg5@open-std.org Received: from smtp-out4.electric.net (smtp-out4.electric.net [192.162.216.193]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by www.open-std.org (Postfix) with ESMTP id E8858356F40 for ; Tue, 6 Oct 2020 20:08:48 +0200 (CEST) Received: from 1kPrOI-000BbH-VM by out4b.electric.net with emc1-ok (Exim 4.94) (envelope-from ) id 1kPrOJ-000Bd2-UI; Tue, 06 Oct 2020 11:08:47 -0700 Received: by emcmailer; Tue, 06 Oct 2020 11:08:47 -0700 Received: from [130.246.132.232] (helo=exchsmtp.stfc.ac.uk) by out4b.electric.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 (Exim 4.94) (envelope-from ) id 1kPrOI-000BbH-VM; Tue, 06 Oct 2020 11:08:46 -0700 Received: from exch01.fed.cclrc.ac.uk (130.246.132.232) by exch01.fed.cclrc.ac.uk (130.246.132.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1913.5; Tue, 6 Oct 2020 19:08:46 +0100 Received: from GBR01-LO2-obe.outbound.protection.outlook.com (104.47.21.54) by exch01.fed.cclrc.ac.uk (130.246.132.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.1.1913.5 via Frontend Transport; Tue, 6 Oct 2020 19:08:46 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QpawZ1VjCct6pb6ZCW5AgoSg3Kmr1vjnD+kd4YXTGjihq/kFKcJTyVntSQ1nCwlcaOqSvVoJbU6AW56X93NuIeRjO9DZjT/HfiBpM/9D2CBt3HvEONOsibi6fBF+5YAeqgpYLuNEPPQe3m1UJQPrpswBSvtlOQJenYqgDjVw61E5vDa36W26Y6fbq8/Oy7wE89O9QDM6N4VonvLljUHFJ4PudBgXTlbXdhS0Y+YfuPgrauGMCIAWYMT5f6fKl6/Z9xoi8Rl00H71PAnwqX+BuBY4QYVrBvppWI9xxjjvI7vi+uy+hskv0dbrcv85/P2rDiJETp6kuGL/hMlMLw0lMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9WHQZkGN4OLZNIfqy+tXPYsEI+lIL2Ln6DvZdk6mS1U=; b=lxz/LuatT4wPF+oARlECFuDL+t+WTjo5vlG7D984mBJ72q8u/gOs8ulpCrZxti1Qh+ALM2IoTRmWvjrY1RVBTMazJ6eOSRT+EVdfQLBQms2timHg+1uY+Gx4C+JB+kAIcEZcBEFTZVTIUfS5+Gmnnu+0cBcPUXsu+H3CEna8pCfUEzfD7ucpRl06RY0B/zyYLp+qVS4J+ztZY3f9+0bTEt9H2UmvsBHVVug2/29Le12eZusqIBq64iNlqKp8HU7XP7TrVzXd+MdJrhTShEHXg0gmJIxnfRiPmMVd0neRb/o+4MXJEVK9SZ8W2IrSTXdgE9ar0QcVRUhsTGiObwr3Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stfc.ac.uk; dmarc=pass action=none header.from=stfc.ac.uk; dkim=pass header.d=stfc.ac.uk; arc=none Received: from LO3P265MB2220.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:107::5) by LNXP265MB2508.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:127::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Tue, 6 Oct 2020 18:08:45 +0000 Received: from LO3P265MB2220.GBRP265.PROD.OUTLOOK.COM ([fe80::6c97:5cca:7a62:2e08]) by LO3P265MB2220.GBRP265.PROD.OUTLOOK.COM ([fe80::6c97:5cca:7a62:2e08%3]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 18:08:45 +0000 From: "Reid, John (-,RAL,SC)" To: 'WG5 List' CC: "John.Reid9@talktalk.net" Subject: Re: [J3] (SC22WG5.6292) RE: [ukfortran] WG5 letter ballot 1 on Fortran 2018 interpretations Thread-Topic: [J3] (SC22WG5.6292) RE: [ukfortran] WG5 letter ballot 1 on Fortran 2018 interpretations Thread-Index: AQHWm8egQyjASLLnjUieFmWmh4FJB6mK3P6w Date: Tue, 6 Oct 2020 18:08:44 +0000 Message-ID: References: <20201004151950.021CA358986@www.open-std.org>, <20201005052003.627873588A5@www.open-std.org>,<20201006100005.BD9D4358A1F@www.open-std.org> In-Reply-To: <20201006100005.BD9D4358A1F@www.open-std.org> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: open-std.org; dkim=none (message not signed) header.d=none;open-std.org; dmarc=none action=none header.from=stfc.ac.uk; x-originating-ip: [92.20.143.4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25e21d09-d467-4df6-98c0-08d86a22dd97 x-ms-traffictypediagnostic: LNXP265MB2508: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AKWtTjTGDYFdJZ/m0dtsamtDt85tdyi6eer+PLjfNLj+3ixwsa+PKeAarSIyRfEZnFLC9QWVU7Wk/ilIds5gzN9nxL4atiVuORZwvZ/BkmqQkg2lDdTw2O1miNHx1BJmKjGA4U52tnT8co4iuEIM5cjdy4nFp8inNuBmwdGE6M8aPQxRilpQC5etCdzibZaskD7O30/sbc7uXzhl/BZ1fKwzPpOk9xu1JnUlbdixGQn3Kzm9MYm5d8R7/av1mBG1PeYgPKrD1JJ8z7b4PuLBzIkMjfVm6ibSA0BJqmrq5ljT+qiwz3pmGoanaUM05ek3KX2mi9cpXhZ9az+SFs5koA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LO3P265MB2220.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(376002)(366004)(346002)(396003)(136003)(39850400004)(19627405001)(5660300002)(316002)(8676002)(2906002)(4326008)(66574015)(33656002)(83380400001)(55016002)(6916009)(186003)(6506007)(52536014)(53546011)(786003)(86362001)(66556008)(66476007)(7696005)(8936002)(478600001)(26005)(76116006)(66946007)(64756008)(66446008)(9686003)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: m0JxCfdeYfDEGJXKn3NctRLYGVW/w89JLNfd0mJdhLQg06PAqau980BphS/1aVoihW8GH1SKgMrw6WaG6LT8a2tRstt3NF5bqkCRMi8DSXxUbHOv1Z5uKUlzKpHUfYpYgi5cbb/GyCBV4uBeZjOnvvkGBmqHQwopTTNekp5e08wEv826mzThG1hqZAbR/VAffs10OSvtxpkXLFgfSiuYhGAnVZl4gb6+jLRy5neL/48snir3UkCyVFqXK2YY7urtArLbrl5vhE2uyhj8v1t723PwIXCLMM30OmzSes8mvWQARYv9esYzylZ2vXUvCCSUSrXHXsu38/coBlV/ujP2oq8csOrbjd8fv4MsFDLvxutQRVTxnXw/UR2GiiEMX2Tofbeqg/5+FsUD5c76WVjJ2MGmOWA89MEMGd05idTUHGeYDgFVGg4c5+khmkF6v7KMPtY0c8Fj6IppduFfo4x7evSniMtisFSeCMRT0ZMX/utRg4SIVa/haDS9c0uQhs4VdtV8DquQMvWzD1ip4k8KaoywUBGlZ3wBFpcM7SzEoXM7UUgGBeIs3fKeXWr7XQuk7xQrAzaqSBH12jviLUU9npCTGHnH6NGFJWkKaoCQD3NUBDj0vYrfFueZoRNXZVD2g/XYt9+/fqBJ/dAfFrAvaQ== x-ms-exchange-transport-forked: True Content-Type: multipart/alternative; boundary="_000_LO3P265MB22203769724FFC99CCD8DF76D30D0LO3P265MB2220GBRP_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LO3P265MB2220.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 25e21d09-d467-4df6-98c0-08d86a22dd97 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 18:08:44.9458 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f66361c-a87e-4158-8f61-99e82db3cac8 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SANR4fcWNBeLo4gTHhVtmA6feUkpKFStbzhfCxMkWjk+lrnKq64zL9FPk8AKykQYP9cIKvcFoMz5HACX056wTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LNXP265MB2508 X-OriginatorOrg: stfc.ac.uk X-EsetResult: clean, is OK X-EsetId: 37303A290F3E236D657664 X-Outbound-IP: 130.246.132.232 X-Env-From: john.reid@stfc.ac.uk X-Proto: esmtps X-Revdns: exch01.rl.ac.uk X-HELO: exchsmtp.stfc.ac.uk X-TLS: TLS1.2:ECDHE-RSA-AES256-SHA384:256 X-Authenticated_ID: X-Virus-Status: Scanned by VirusSMART (c) X-Virus-Status: Scanned by VirusSMART (b) X-PolicySMART: 3590380, 22539278 X-PolicySMART: 3590380, 22539278 Sender: owner-sc22wg5@open-std.org Precedence: bulk --_000_LO3P265MB22203769724FFC99CCD8DF76D30D0LO3P265MB2220GBRP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Malcolm, Here are my comments (1) The present code is wrong and I was going to suggest changing "-10" to "-9"= but I far prefer Anton's suggestion: images_spare =3D 0 if ( NUM_IMAGES() .GE. 10 ) images_spare =3D 1 if ( NUM_IMAGES() .GE. 200 ) images_spare =3D NUM_IMAGES()/100 It is absolutely clear what this does, which I see as an example of good pr= actice. It does not need a comment to explain what is going on. This can be= changed to ! Choose how many images to keep as spares. (2) I agree with you. (3) Yes, we should test status. I think IF (status/=3D0 .AND. status/=3DSTAT_FAILED_IMAGE) EXIT outer would be OK in both cases. Cheers, John. ________________________________ From: J3 on behalf of Reid, John (-,RAL= ,SC) via J3 Sent: 06 October 2020 10:46 To: 'WG5 List' ; General J3 interest list Cc: Reid, John (-,RAL,SC) ; Malcolm Cohen Subject: [J3] (SC22WG5.6292) RE: [ukfortran] WG5 letter ballot 1 on Fortran= 2018 interpretations Malcolm, I have been working on C.6.8 in response from comments by Nathan Weeks. I w= as planning to submit a paper to J3 in the hope that it would work on it du= ring the J3 meeting. The latest draft is attached. I will now rewrite this = as a WG5 interp. vote. Comments from you or anyone else will be most welcom= e. I will comment on your suggestions later today. Cheers John. ________________________________ From: J3 on behalf of Malcolm Cohen via= J3 Sent: 05 October 2020 06:13 To: 'WG5 List' Cc: Malcolm Cohen Subject: [J3] (SC22WG5.6291) RE: [ukfortran] WG5 letter ballot 1 on Fortran= 2018 interpretations This is not my vote... I am considering: -N- --- F18/015 Example in C.6.8 is wrong I have three problems with this interp; the first two are the same issues A= nton raised. Before I commit my suggestions to a vote, I am floating this i= n hope of receiving some enlightening comments... (1) I don't see a strong reason to follow the existing formula precisely - 0.5%= is not terribly close to 1% so the 1% comment is a bit misleading anyway. = So how about: ! With 10+ images, keep at least 1% spare. images_spare =3D MERGE(0,CEILING(NUM_IMAGES()/100.0),NUM_IMAGES()<10) Obviously this keeps more spare images than the original (the same number u= p to 100, +1 when >100). (2) I agree that a variable with the same name as an intrinsic is not good styl= e. "team_num" would be okay. But I do not agree that the intrinsic should be used at line 88 - that shou= ld be the variable. (3) I find the use of STAT=3D followed by ignoring the result to be very poor s= tyle indeed - unacceptably poor. I note that other places have e.g. IF (STATUS/=3D0 .AND. STATUS/=3DSTAT_FAILED_IMAGE) EXIT outer I think this should be the case for the END TEAM and its following SYNC ALL= statement. Or, if there is some good reason why not, that needs to be at least briefly= explained in a comment after each of those statements. Cheers, -- ..............Malcolm Cohen, NAG Oxford/Tokyo. This email and any attachments are intended solely for the use of the named= recipients. If you are not the intended recipient you must not use, disclo= se, copy or distribute this email or any of its attachments and should noti= fy the sender immediately and delete this email from your system. UK Resear= ch and Innovation (UKRI) has taken every reasonable precaution to minimise = risk of this email or any attachments containing viruses or malware but the= recipient should carry out its own virus and malware checks before opening= the attachments. UKRI does not accept any liability for any losses or dama= ges which the recipient may sustain due to presence of any viruses. Opinion= s, conclusions or other information in this message and attachments that ar= e not related directly to UKRI business are solely those of the author and = do not represent the views of UKRI. --_000_LO3P265MB22203769724FFC99CCD8DF76D30D0LO3P265MB2220GBRP_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Malcolm,

Here are my comments

(1)
The present code is wrong and I was going to suggest changing "-10&quo= t; to "-9" but I far prefer Anton's suggestion:
    images_spare =3D 0
    if ( NUM_IMAGES() .GE. 10  ) images_spare =3D 1
    if ( NUM_IMAGES() .GE. 200 ) images_spare =3D NUM_IMAGES()/10= 0
It is absolutely clear what this does, which I see as an example of good pr= actice. It does not need a comment to explain what is going on. This can be= changed to
    ! Choose how many images to keep as spares.

(2)
I agree with you.

(3)
Yes, we should test status. I think
    IF (status/=3D0 .AND. status/=3DSTAT_FAILED_IMAGE) EXIT outer=
would be OK in both cases.

Cheers,

John.
From: J3 <j3-bounces@mai= lman.j3-fortran.org> on behalf of Reid, John (-,RAL,SC) via J3 <j3@ma= ilman.j3-fortran.org>
Sent: 06 October 2020 10:46
To: 'WG5 List' <sc22wg5@open-std.org>; General J3 interest lis= t <j3@mailman.j3-fortran.org>
Cc: Reid, John (-,RAL,SC) <john.reid@stfc.ac.uk>; Malcolm Cohe= n <malcolm@nag-j.co.jp>
Subject: [J3] (SC22WG5.6292) RE: [ukfortran] WG5 letter ballot 1 on = Fortran 2018 interpretations
 
Malcolm,

I have been working on C.6.8 in response from comments by Nathan Weeks. I w= as planning to submit a paper to J3 in the hope that it would work on it du= ring the J3 meeting. The latest draft is attached. I will now rewrite this = as a WG5 interp. vote. Comments from you or anyone else will be most welcome.

I will comment on your suggestions later today.

Cheers

John.

From: J3 <j3-bounces@m= ailman.j3-fortran.org> on behalf of Malcolm Cohen via J3 <j3@mailman.= j3-fortran.org>
Sent: 05 October 2020 06:13
To: 'WG5 List' <sc22wg5@open-std.org>
Cc: Malcolm Cohen <malcolm@nag-j.co.jp>
Subject: [J3] (SC22WG5.6291) RE: [ukfortran] WG5 letter ballot 1 on = Fortran 2018 interpretations
 
This is not my vote... I am considering:

-N- --- F18/015  Example in C.6.8 is wrong

I have three problems with this interp; the first two are the same issues A= nton raised. Before I commit my suggestions to a vote, I am floating this i= n hope of receiving some enlightening comments...

(1)
I don't see a strong reason to follow the existing formula precisely - 0.5%= is not terribly close to 1% so the 1% comment is a bit misleading anyway. = So how about:

! With 10+ images, keep at least 1% spare.
images_spare =3D MERGE(0,CEILING(NUM_IMAGES()/100.0),NUM_IMAGES()<10)
Obviously this keeps more spare images than the original (the same number u= p to 100, +1 when >100).

(2)
I agree that a variable with the same name as an intrinsic is not good styl= e.
"team_num" would be okay.
But I do not agree that the intrinsic should be used at line 88 - that shou= ld be the variable.

(3)
I find the use of STAT=3D followed by ignoring the result to be very poor s= tyle indeed - unacceptably poor. I note that other places have e.g.
    IF (STATUS/=3D0 .AND. STATUS/=3DSTAT_FAILED_IMAGE) EXIT = outer
I think this should be the case for the END TEAM and its following SYNC ALL= statement.
Or, if there is some good reason why not, that needs to be at least briefly= explained in a comment after each of those statements.

Cheers,
--
..............Malcolm Cohen, NAG Oxford/Tokyo.


This email and any attachments are intende= d solely for the use of the named recipients. If you are not the intended r= ecipient you must not use, disclose, copy or distribute this email or any o= f its attachments and should notify the sender immediately and delete this email from your system. UK Research= and Innovation (UKRI) has taken every reasonable precaution to minimise ri= sk of this email or any attachments containing viruses or malware but the r= ecipient should carry out its own virus and malware checks before opening the attachments. UKRI does not acc= ept any liability for any losses or damages which the recipient may sustain= due to presence of any viruses. Opinions, conclusions or other information= in this message and attachments that are not related directly to UKRI business are solely those of the aut= hor and do not represent the views of UKRI.

--_000_LO3P265MB22203769724FFC99CCD8DF76D30D0LO3P265MB2220GBRP_--